[Nepomuk] Review Request: Nepomukshell autocomplete fixed

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104606/#review12469
-----------------------------------------------------------


If possible please split these into 2 patches, one for automatically selecting the first option, and the second for not showing the popup when moving around.

And please follow - http://techbase.kde.org/Policies/Kdelibs_Coding_Style


queryeditor.h
<http://git.reviewboard.kde.org/r/104606/#comment9779>

    Unnecessary whitespace



queryeditor.h
<http://git.reviewboard.kde.org/r/104606/#comment9780>

    ditto



queryeditor.cpp
<http://git.reviewboard.kde.org/r/104606/#comment9783>

    This section needs to be properly indented.



queryeditor.cpp
<http://git.reviewboard.kde.org/r/104606/#comment9785>

    Proper spacing please



queryeditor.cpp
<http://git.reviewboard.kde.org/r/104606/#comment9784>

    unnecessary line



queryeditor.cpp
<http://git.reviewboard.kde.org/r/104606/#comment9781>

    Why the extra whitespace?


- Vishesh Handa


On April 15, 2012, 1:52 p.m., Raveendra  Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104606/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 1:52 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Earlier 1st completion suggestion was not selected by default in the completions list in the widget. I have tried to fix it. Now it is working. And also completion widget does not pop out automatically when cursor is in beteween the letters of a keyword. 
> 
> 
> Diffs
> -----
> 
>   queryeditor.h e8d815d 
>   queryeditor.cpp 9745a1b 
> 
> Diff: http://git.reviewboard.kde.org/r/104606/diff/
> 
> 
> Testing
> -------
> 
> Used it for many SPARQL queries.And confirmed that 1st completion is selected by default in all cases.
> 
> 
> Thanks,
> 
> Raveendra  Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120415/4204b759/attachment.html>