[Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon

[Smit Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102726/
-----------------------------------------------------------

(Updated Sept. 29, 2011, 7:29 p.m.)


Review request for Nepomuk.


Changes
-------

Ah bit late with the update , i followed everyone's suggestions and made the patch , i have set the timer to 3 seconds and have tested it and it works , there is one obvious flaw if indexing takes 4 seconds , and timer goes out at 3 seconds so system tray will again be active 1 second but this can't be resolved unless we know the exact amount of indexing time.


Description
-------

Now that i have added a timer it should fix the rapid passive/active changes in nepomuk system tray icon.


This addresses bugs Active/Non, active, controller, of, and state.
    http://bugs.kde.org/show_bug.cgi?id=Active/Non
    http://bugs.kde.org/show_bug.cgi?id=active
    http://bugs.kde.org/show_bug.cgi?id=controller
    http://bugs.kde.org/show_bug.cgi?id=of
    http://bugs.kde.org/show_bug.cgi?id=state


Diffs (updated)
-----

  nepomuk/controller/systray.h 06261b7 
  nepomuk/controller/systray.cpp b67eb6c 

Diff: http://git.reviewboard.kde.org/r/102726/diff/diff


Testing
-------


Thanks,

Smit Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110929/7b088628/attachment.html>