[Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102726/#review6889
-----------------------------------------------------------



nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6109>

    The name of the slot is too generic. And more importantly: it is not defined.
    You obviously did not test at all. :)



nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6107>

    what is this timer good for now?



nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6108>

    You should check if the timer is already running.
    Also there is no need to start the timer if the status is already active.


- Sebastian Trueg


On Sept. 28, 2011, 5:57 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102726/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 5:57 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Now that i have added a timer it should fix the rapid passive/active changes in nepomuk system tray icon.
> 
> 
> This addresses bugs Active/Non, active, controller, of, and state.
>     http://bugs.kde.org/show_bug.cgi?id=Active/Non
>     http://bugs.kde.org/show_bug.cgi?id=active
>     http://bugs.kde.org/show_bug.cgi?id=controller
>     http://bugs.kde.org/show_bug.cgi?id=of
>     http://bugs.kde.org/show_bug.cgi?id=state
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/systray.h 06261b7 
>   nepomuk/controller/systray.cpp b67eb6c 
> 
> Diff: http://git.reviewboard.kde.org/r/102726/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110928/c09890ac/attachment.html>