[Nepomuk] Review Request: Fix for the rapid change in state of nepomuk system tray icon
Sebastian Trueg
sebastian at trueg.de
Sun Oct 2 08:46:34 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102726/#review6994
-----------------------------------------------------------
Now it looks much better and only a few small things remain (basically only cleanup).
nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6171>
whitespace.
nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6172>
please remove these changes in space from the patch.
nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6173>
please remove these changes in space from the patch.
nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6174>
please remove these changes in space from the patch.
nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6175>
please remove these changes in space from the patch.
nepomuk/controller/systray.cpp
<http://git.reviewboard.kde.org/r/102726/#comment6170>
Utterly pointless variable. :P
- Sebastian Trueg
On Oct. 1, 2011, 5:06 p.m., Smit Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102726/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2011, 5:06 p.m.)
>
>
> Review request for Nepomuk.
>
>
> Description
> -------
>
> Now that i have added a timer it should fix the rapid passive/active changes in nepomuk system tray icon.
>
>
> This addresses bugs Active/Non, active, controller, of, and state.
> http://bugs.kde.org/show_bug.cgi?id=Active/Non
> http://bugs.kde.org/show_bug.cgi?id=active
> http://bugs.kde.org/show_bug.cgi?id=controller
> http://bugs.kde.org/show_bug.cgi?id=of
> http://bugs.kde.org/show_bug.cgi?id=state
>
>
> Diffs
> -----
>
> nepomuk/controller/systray.h 06261b7
> nepomuk/controller/systray.cpp b67eb6c
>
> Diff: http://git.reviewboard.kde.org/r/102726/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Smit Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20111002/6220ab7a/attachment.html>
More information about the Nepomuk
mailing list