[Nepomuk] Re: Review Request: Fix Search excerpts

Sebastian Trueg sebastian at trueg.de
Wed May 25 19:59:39 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101437/#review3518
-----------------------------------------------------------

Ship it!


very nice.

- Sebastian


On May 25, 2011, 3:11 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101437/
> -----------------------------------------------------------
> 
> (Updated May 25, 2011, 3:11 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> This new Literal Term never added the search variable via QBD::addFullTextSearchTerm, and therefore search excerpts were never queried.
> 
> I've only added the terms which we query via bif:contains(), not the regex ones.
> 
> 
> Diffs
> -----
> 
>   nepomuk/query/literalterm.cpp 338b77e 
>   nepomuk/query/querybuilderdata_p.h f2ca601 
> 
> Diff: http://git.reviewboard.kde.org/r/101437/diff
> 
> 
> Testing
> -------
> 
> Nepomuk::Query::Result::excerpt() returns the excerpt.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110525/4817a47b/attachment.htm 


More information about the Nepomuk mailing list