[Nepomuk] Re: Review Request: Watch indexed folders for file modifications

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101279/#review3087
-----------------------------------------------------------

Ship it!


Looks perfect to me. This is going to increase performance a LOT. We should have thought of this sooner.

- Vishesh


On May 3, 2011, 9:05 a.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101279/
> -----------------------------------------------------------
> 
> (Updated May 3, 2011, 9:05 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Previously the filewatch service did not watch indexed folders for file modifications although the necessary slots already existed. This patch adds the required flags to make indexed folders watched for modifications.
> 
> Although this is a trivial patch it allows interested people to take a look at the workings of the file watch service.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/filewatch/nepomukfilewatch.cpp 5bc5f41 
> 
> Diff: http://git.reviewboard.kde.org/r/101279/diff
> 
> 
> Testing
> -------
> 
> Tested by adding random text strings into a text file and then searching for it. The new contents were indexed immediately.
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110503/8fc89aa1/attachment-0001.htm