[Nepomuk] Re: Review Request: Actions on Notification Events

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100988/#review2273
-----------------------------------------------------------


A minor comment.


nepomuk/services/strigi/eventmonitor.h
<http://git.reviewboard.kde.org/r/100988/#comment1964>

    Why move this code block?


- Vishesh


On March 31, 2011, 12:33 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100988/
> -----------------------------------------------------------
> 
> (Updated March 31, 2011, 12:33 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> The Nepomuk strigi service may pause/resume indexing based on the power settings ( battery or AC ) or the amount of hard-drive space left. When it changes its state it emits a notification. These notifications should have some kind of actions which allow the user to forcefully pause/resume the indexing. 
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/strigi/eventmonitor.h b0ec97d 
>   nepomuk/services/strigi/eventmonitor.cpp 51ae599 
> 
> Diff: http://git.reviewboard.kde.org/r/100988/diff
> 
> 
> Testing
> -------
> 
> Added the notification actions so when paused/resumed , users have the option of either resuming or suspending the event
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110331/05cb2097/attachment.htm