[Nepomuk] Re: Actions on Notification Events

[Who Knows]

i have fixed things accordingly , for future patches (for other junior jobs)
i will use review board.

On Tue, Mar 29, 2011 at 9:49 PM, Who Knows <who828 at gmail.com> wrote:

> Finally i have done it !
>
>
> On Tue, Mar 29, 2011 at 9:19 PM, Who Knows <who828 at gmail.com> wrote:
>
>> I hope this time i have covered all the bases !!
>>
>>
>> On Tue, Mar 29, 2011 at 8:58 PM, Who Knows <who828 at gmail.com> wrote:
>>
>>> okay i have fixed the other bugs as well
>>>
>>>
>>> On Tue, Mar 29, 2011 at 6:29 PM, Who Knows <who828 at gmail.com> wrote:
>>>
>>>> umm sorry about that, anyway i have fixed the code formatting errors.
>>>>
>>>>
>>>> On Tue, Mar 29, 2011 at 5:10 PM, Sebastian Trüg <trueg at kde.org> wrote:
>>>>
>>>>> the patch looks correct. But before I test it may I ask you to fix the
>>>>> code formatting please:
>>>>> - Correct indentation (4 spaces)
>>>>> - spaces around "="
>>>>> - an empty line between the method definition and the "private:"
>>>>> keyword
>>>>> - please move the method implementation to the correct place. Ideally
>>>>> the order of methods should be the same in the header and the source
>>>>> file.
>>>>>
>>>>> Cheers,
>>>>> Sebastian
>>>>>
>>>>> On 03/28/2011 07:16 PM, Who Knows wrote:
>>>>> > Hey, i finish tried to implement actions on notification so user can
>>>>> > pause/resume indexing if they want but i have not been able to test
>>>>> it
>>>>> > out personally so if there are any bugs or some other problems just
>>>>> let
>>>>> > me know.
>>>>> >
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > Nepomuk mailing list
>>>>> > Nepomuk at kde.org
>>>>> > https://mail.kde.org/mailman/listinfo/nepomuk
>>>>> _______________________________________________
>>>>> Nepomuk mailing list
>>>>> Nepomuk at kde.org
>>>>> https://mail.kde.org/mailman/listinfo/nepomuk
>>>>>
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110331/407cd730/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: difference.diff
Type: text/x-patch
Size: 3123 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/nepomuk/attachments/20110331/407cd730/attachment.diff