[Nepomuk] Re: Review Request: Fixed range of nfo:interlaceMode in the PNG analyzer

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101704/#review4127
-----------------------------------------------------------


This review has been submitted with commit c4c9c5073f3a2aa142f58642aa0c788c409b3f73 by Sebastian Trueg to branch master.

- Commit


On June 20, 2011, 2:18 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101704/
> -----------------------------------------------------------
> 
> (Updated June 20, 2011, 2:18 p.m.)
> 
> 
> Review request for Nepomuk and Strigi.
> 
> 
> Summary
> -------
> 
> nfo:interlaceMode has the range xsd:boolean. This might be a bit weird but in the end makes sense since we mostly want to know if an image is interlaced or not. (Down the road we might think of adding another property which holds the name of the interlacing algorithm used.)
> This patch fixes the range in the PNG analyzer which till now used a string naming the algorithm name.
> 
> 
> Diffs
> -----
> 
>   lib/endanalyzers/pngendanalyzer.cpp 804bd5f 
> 
> Diff: http://git.reviewboard.kde.org/r/101704/diff
> 
> 
> Testing
> -------
> 
> Tested on a few PNGs. The value is correct.
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110624/941071a9/attachment.htm