[Nepomuk] Re: Review Request: Convert DateTime in EXIF date to time_t

Commit Hook null at kde.org
Fri Jun 24 16:24:18 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101672/#review4128
-----------------------------------------------------------


This review has been submitted with commit 65acdcd5d2bed23a064f3be6e56d2fc47a2e017f by Sebastian Trueg to branch master.

- Commit


On June 18, 2011, 7:41 a.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101672/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 7:41 a.m.)
> 
> 
> Review request for Nepomuk, Strigi, Jos van den Oever, and Vishesh Handa.
> 
> 
> Summary
> -------
> 
> The jpeg plugin uses nie:contentCreated for the DateTime field in EXIF data. nie:contentCreated has a range of xsd:dateTime but so far the plugin simply exports the value from EXIF which uses a non-standard format "YYYY:MM:DD hh:mm:ss". So far we had a hack in Nepomuk which would convert this string to a QDateTime. IMHO this should be done in the plugin instead. This patch does exactly that.
> 
> 
> Diffs
> -----
> 
>   plugins/endplugins/jpegendanalyzer.cpp 928fa24 
> 
> Diff: http://git.reviewboard.kde.org/r/101672/diff
> 
> 
> Testing
> -------
> 
> Tested via xmlindexer - the created int value matches the actual value.
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110624/44357af9/attachment.htm 


More information about the Nepomuk mailing list