[Nepomuk] Re: Review Request: Port raptor serializer to raptor2

[Sebastian Trueg]

> On June 24, 2011, 12:17 p.m., Sebastian Trueg wrote:
> > This is a bit messy for my taste. So please put it in a branch and we will fix it in there.
> 
> Artem Serebriyskiy wrote:
>     Ok. branch is 'raptor2'

very good. can you close this review then, please.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101741/#review4123
-----------------------------------------------------------


On June 24, 2011, 11:09 a.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101741/
> -----------------------------------------------------------
> 
> (Updated June 24, 2011, 11:09 a.m.)
> 
> 
> Review request for Nepomuk and Soprano.
> 
> 
> Summary
> -------
> 
> Port Raptor serializer to libraptor2 + provide test for serializers
> 
> 
> Diffs
> -----
> 
>   backends/redland/redlandqueryresult.cpp dbddcba 
>   cmake/modules/FindRaptor.cmake 6347647 
>   parsers/raptor/CMakeLists.txt 2adf527 
>   parsers/raptor/raptor-config.h.cmake dc35028 
>   parsers/raptor/raptorparser.h e6a7f99 
>   parsers/raptor/raptorparser.cpp 0aabb73 
>   serializers/raptor/raptorserializer.h 39037bb 
>   serializers/raptor/raptorserializer.cpp 959f80a 
>   test/CMakeLists.txt a17805a 
>   test/serializetest.h PRE-CREATION 
>   test/serializetest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101741/diff
> 
> 
> Testing
> -------
> 
> There were no tests in soprano for serializers. So I wrote one( based on parsertest). This, unfortunately, means that it is not possible to rely on this test to detect if port to raptor2 is correct.
> Nevertheless, evrything is compiling on my system and this new test is successfully passed.
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110624/09108c08/attachment-0001.htm