[Nepomuk] Review Request: Do not use Nepomuk::Types in the nepomukindexer

Vishesh Handa handa.vish at gmail.com
Mon Jun 6 12:50:45 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101522/
-----------------------------------------------------------

Review request for Nepomuk and Sebastian Trueg.


Summary
-------

Nepomuk::Types classes are very expensive as they load all the type properties in one go. While this was acceptable when the WriterData was initialized only once, with the new Strigi Service architecture, the WriterData is initialized each time a file in indexed. It doesn't make any sense to load all the properties each time. 

Specially since we only use the range() and literalRangeType() of Nepomuk::Types::Property 


Diffs
-----

  nepomuk/services/strigi/indexer/nepomukindexwriter.cpp 71d2e54 

Diff: http://git.reviewboard.kde.org/r/101522/diff


Testing
-------

Compared previous and current indexed data for an mp3 file.


Thanks,

Vishesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110606/97007677/attachment.htm 


More information about the Nepomuk mailing list