[Nepomuk] Re: Review Request: Thread safey in the Query Service
Sebastian Trueg
sebastian at trueg.de
Sat Jul 30 14:34:55 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102129/#review5233
-----------------------------------------------------------
Ship it!
- Sebastian
On July 30, 2011, 12:07 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102129/
> -----------------------------------------------------------
>
> (Updated July 30, 2011, 12:07 a.m.)
>
>
> Review request for Nepomuk and Sebastian Trueg.
>
>
> Summary
> -------
>
> The Nepomuk::Query::Folder::initialListingDone() function can be called via dbus at any point via the FolderConnection, at that point the listingFinished() function might be in the process of changing m_initialListingDone's value => CRASH
>
> Ditto with Nepomuk::Query::Folder::entries(). It can be called via FolderConnection's list method. ( See the bug report )
>
> In order to remove the const_cast, the function will have to be non-const. Your call.
>
>
> This addresses bug 269650.
> http://bugs.kde.org/show_bug.cgi?id=269650
>
>
> Diffs
> -----
>
> nepomuk/services/queryservice/folder.h 1f489e3
> nepomuk/services/queryservice/folder.cpp d4b58f3
>
> Diff: http://git.reviewboard.kde.org/r/102129/diff
>
>
> Testing
> -------
>
> No testing has been done. How would you test such things?
>
>
> Thanks,
>
> Vishesh
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110730/e6f236a2/attachment.htm
More information about the Nepomuk
mailing list