[Nepomuk] Re: Review Request: Add CMake script that wraps nepomuk-simpleresource-rcgen

[Sebastian Trueg]

> On July 28, 2011, 9:25 a.m., Sebastian Trueg wrote:
> > Could you update this to be a review against kde-runtime instead?
> 
> Artem Serebriyskiy wrote:
>     Not entirely. I can't move FindNepomuk to kde-runtime. But I can move the new cmake script. But what is wrong for it in beeing in kdelibs ? It is anyway optional include for now.
> 
> Sebastian Trueg wrote:
>     We cannot have a cmake script which depends on kde-runtime in kdelibs. That is simply not possible. And I don't think you need to change FindNepomuk.cmake. For now it is fone if developers simply include the new cmake macro manually. Once we move all of the DMS client to kdelibs - then we can also add it to FindNepomuk.cmake.
> 
> Artem Serebriyskiy wrote:
>     Ok. No problems to do this.
>     But don't blame me for asking - may be it is better to move DMS to kdelibs ? 4.7 is already released ;)
>     * And there is no "real" dependency - include is optional, find_program is optional too, so if you do pind_package(Nepomuk) without kde-runtime installed, there will be no error - simpleresource rcgen script will be simply not found and it will be ignored.
>     
>     But, as I mention, I can easily do this very quickly if you think it is necessary.
> 
> Vishesh Handa wrote:
>     I agree. Lets move the DMS lib to kdelibs. That way we can easily port nepomuklib to the DMS, instead of ugly DBus calls.

ok. :)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101963/#review5161
-----------------------------------------------------------


On July 24, 2011, 8:27 a.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101963/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 8:27 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This patch addes new cmake script to kdelibs that wraps calls to nepomuk_simpleresource_rcgen.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/CMakeLists.txt 65379db 
>   cmake/modules/FindNepomuk.cmake 7307649 
>   cmake/modules/NepomukAddSimpleResourceClasses.cmake PRE-CREATION 
>   cmake/modules/NepomukMacros.cmake 14acd2b 
> 
> Diff: http://git.reviewboard.kde.org/r/101963/diff
> 
> 
> Testing
> -------
> 
> On my system. Used in Nepomuk Web Extractor.
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110730/9cd80ce4/attachment-0001.htm