[Nepomuk] Re: Review Request: watch for the query service to appear/disappear

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102112/#review5206
-----------------------------------------------------------



nepomuk/query/queryserviceclient.h
<http://git.reviewboard.kde.org/r/102112/#comment4720>

    Please match the signal name to the static method, ie. call it serviceAvailabilityChanged.


- Sebastian


On July 28, 2011, 4:09 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102112/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 4:09 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> right now, if a queryserviceclient is created and the query service isn't running, the connection to dbus won't be done and even if the service starts, so all query() calls will fail.
> 
> this makes a new connection each time the service reapperars.
> fixes also queries done in applications that gets auto started, like the workspace
> 
> 
> Diffs
> -----
> 
>   nepomuk/query/queryserviceclient.h 234d4b0 
>   nepomuk/query/queryserviceclient.cpp cd402e1 
> 
> Diff: http://git.reviewboard.kde.org/r/102112/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110729/04c4f62d/attachment.htm