[Nepomuk] Re: Review Request: storeResource should return the mappings

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102128/#review5203
-----------------------------------------------------------



nepomuk/interfaces/org.kde.nepomuk.DataManagement.xml
<http://git.reviewboard.kde.org/r/102128/#comment4713>

    this looks very wrong. It should be "a{ss}".



nepomuk/services/storage/datamanagementcommand.h
<http://git.reviewboard.kde.org/r/102128/#comment4714>

    please use the provided encoding methods instead.



nepomuk/services/storage/lib/dbustypes.h
<http://git.reviewboard.kde.org/r/102128/#comment4715>

    this is the method you should use above.



nepomuk/services/storage/lib/dbustypes.cpp
<http://git.reviewboard.kde.org/r/102128/#comment4716>

    why both?



nepomuk/services/storage/lib/storeresourcesjob.h
<http://git.reviewboard.kde.org/r/102128/#comment4717>

    docs! this is a public class.



nepomuk/services/storage/lib/storeresourcesjob.cpp
<http://git.reviewboard.kde.org/r/102128/#comment4718>

    whitespace.



nepomuk/services/storage/lib/storeresourcesjob.cpp
<http://git.reviewboard.kde.org/r/102128/#comment4719>

    Again please use the conversion methods. QUrl::toString() is not great when it comes to converting URIs and we still might have legacy file URLs in the database which would not get converted properly using QUrl(url.toString()).


- Sebastian


On July 29, 2011, 9:04 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102128/
> -----------------------------------------------------------
> 
> (Updated July 29, 2011, 9:04 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> When SimpleResources are passed on to storeResources they are run through an identification process, so as to avoid duplicates. The resources which fail the identification process are then created.
> 
> It is nice to have a mapping of the SimpleResource uris and the uris that are finally pushed in the Nepomuk Repository.
> 
> I've tried for over 2 days to transfer the stupid QHash<QUrl,QUrl> over dbus. I've now given up and passed it as a QHash<QString,QString>.
> 
> 
> Diffs
> -----
> 
>   nepomuk/interfaces/org.kde.nepomuk.DataManagement.xml 0172373 
>   nepomuk/services/storage/datamanagementadaptor.h 05ef64c 
>   nepomuk/services/storage/datamanagementadaptor.cpp 4ca8114 
>   nepomuk/services/storage/datamanagementcommand.h c970404 
>   nepomuk/services/storage/datamanagementmodel.h 9722157 
>   nepomuk/services/storage/datamanagementmodel.cpp 062cdcc 
>   nepomuk/services/storage/lib/CMakeLists.txt 2189a7f 
>   nepomuk/services/storage/lib/datamanagement.h 5b31603 
>   nepomuk/services/storage/lib/datamanagement.cpp 9c570b0 
>   nepomuk/services/storage/lib/dbustypes.h 900e219 
>   nepomuk/services/storage/lib/dbustypes.cpp 27fd0f4 
>   nepomuk/services/storage/lib/simpleresourcegraph.h 386b8c1 
>   nepomuk/services/storage/lib/simpleresourcegraph.cpp 3bab264 
>   nepomuk/services/storage/lib/storeresourcesjob.h PRE-CREATION 
>   nepomuk/services/storage/lib/storeresourcesjob.cpp PRE-CREATION 
>   nepomuk/services/storage/test/asyncclientapitest.cpp c430f06 
>   nepomuk/services/strigi/indexer/nepomukindexwriter.cpp 8164b69 
> 
> Diff: http://git.reviewboard.kde.org/r/102128/diff
> 
> 
> Testing
> -------
> 
> Tested while using metadata sharing. The mappings are correctly returned.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110729/a43f3d29/attachment-0001.htm