[Nepomuk] Re: Review Request: WritebackJob draft

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102094/#review5136
-----------------------------------------------------------



nepomuk/services/writeback/service/writebackjob.h
<http://git.reviewboard.kde.org/r/102094/#comment4627>

    there is actually no need for the parameter since you have m_resource.



nepomuk/services/writeback/service/writebackjob.h
<http://git.reviewboard.kde.org/r/102094/#comment4628>

    This slot is not correct. The plugin's finished signal has only one parameter: the plugin itself. Thus, the connection will fail since the signal does not provide a resource.



nepomuk/services/writeback/service/writebackjob.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4629>

    Maybe just as an exersise add
    Q_ASSERT(m_resource.isValid())
    and
    Q_ASSERT(!m_plugins.isEmpty())



nepomuk/services/writeback/service/writebackjob.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4630>

    This is still wrong. I even provided the code!



nepomuk/services/writeback/service/writebackservice.h
<http://git.reviewboard.kde.org/r/102094/#comment4631>

    this is not used.



nepomuk/services/writeback/service/writebackservice.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4632>

    The !plugins.contains(plugin) is pointless. The list can never contain the plugin since you just created it.



nepomuk/services/writeback/service/writebackservice.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4633>

    You do this within the loop!
    Think about what you actually want to do!



nepomuk/services/writeback/service/writebackservice.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4634>

    same as above.



nepomuk/services/writeback/service/writebackservice.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4635>

    same as above.


- Sebastian


On July 27, 2011, 6:55 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102094/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 6:55 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This is my first attempt to write the writebackjob for the writebackservice.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/writeback/lib/writebackplugin.h 6bcdfd3 
>   nepomuk/services/writeback/lib/writebackplugin.cpp 2a52a31 
>   nepomuk/services/writeback/service/CMakeLists.txt 949b379 
>   nepomuk/services/writeback/service/writebackjob.h e69de29 
>   nepomuk/services/writeback/service/writebackjob.cpp e69de29 
>   nepomuk/services/writeback/service/writebackservice.h a9821a6 
>   nepomuk/services/writeback/service/writebackservice.cpp be5c738 
> 
> Diff: http://git.reviewboard.kde.org/r/102094/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110727/3a8a4f7e/attachment-0001.htm