[Nepomuk] Re: Review Request: WritebackJob draft

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102094/#review5126
-----------------------------------------------------------



nepomuk/services/writeback/lib/writebackplugin.h
<http://git.reviewboard.kde.org/r/102094/#comment4618>

    The plugin is still missing a means to report the success.
    It could even return which properties have been written. That would help in optimizing later on.



nepomuk/services/writeback/service/writebackjob.h
<http://git.reviewboard.kde.org/r/102094/#comment4612>

    this is not a public slot. the rest are not either. Only start() should be public.



nepomuk/services/writeback/service/writebackjob.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4613>

    You should also do something with the plugin.



nepomuk/services/writeback/service/writebackjob.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4615>

    Since this slot is called slotWritebackFinsihed I assume you mean to connect it to the plugin's finished() slot. Then this new connection is pointless, especially since you delete the plugin later on.



nepomuk/services/writeback/service/writebackjob.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4614>

    Only try the next one if the previous one failed to write anything back.
    Either that or allow multiple plugins to write back data. I am not sure what is best. Only allowing one reduces the power of the system. But allowing more than one could lead to the same data be written multiple times...



nepomuk/services/writeback/service/writebackjob.cpp
<http://git.reviewboard.kde.org/r/102094/#comment4616>

    This slot is pointless. You should instead emitResult() once a plugin has performed the writeback successfully or all have performed their writeback - depending on which solution you choose.


- Sebastian


On July 26, 2011, 7:03 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102094/
> -----------------------------------------------------------
> 
> (Updated July 26, 2011, 7:03 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This is my first attempt to write the writebackjob for the writebackservice.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/writeback/lib/writebackplugin.h 6bcdfd3 
>   nepomuk/services/writeback/lib/writebackplugin.cpp 2a52a31 
>   nepomuk/services/writeback/service/CMakeLists.txt 949b379 
>   nepomuk/services/writeback/service/writebackjob.h e69de29 
>   nepomuk/services/writeback/service/writebackjob.cpp e69de29 
>   nepomuk/services/writeback/service/writebackservice.h a9821a6 
> 
> Diff: http://git.reviewboard.kde.org/r/102094/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110726/ed2d61d0/attachment-0001.htm