[Nepomuk] Re: Review Request: Add(return) signal to Nepomuk::Utils::SearchWidget

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101874/#review4635
-----------------------------------------------------------

Ship it!


Other than the small indentation issue: very good. Please push.

- Sebastian


On July 9, 2011, 12:52 p.m., Artem Serebriyskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101874/
> -----------------------------------------------------------
> 
> (Updated July 9, 2011, 12:52 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> 1. Add currentResourceChanged signal back to SearchWidget. I think it is more convinient, then capturing selectionChanged and quering for currentResource. Ideologically, selection and currentIndex are different things and there can be currentIndex without any selection.
> 
> 
> Diffs
> -----
> 
>   nepomuk/utils/searchwidget.h b7dc7ea 
>   nepomuk/utils/searchwidget.cpp 5b1648b 
>   nepomuk/utils/searchwidget_p.h 50038e7 
> 
> Diff: http://git.reviewboard.kde.org/r/101874/diff
> 
> 
> Testing
> -------
> 
> works on my system.
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110712/db187c6c/attachment.htm