[Nepomuk] Re: Review Request: Extra function for SimpleResource and SimpleResourceGraph

[Artem Serebriyskiy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101856/
-----------------------------------------------------------

(Updated July 7, 2011, 8:08 p.m.)


Review request for Nepomuk.


Changes
-------

Implement some issues mentioned by Trueg and Vishesh.


Summary
-------

Extra functions to SimpleResource|Graph
1. Operator comparison for Graph
2. addGraph for Graph - merges 2 graphs into one
3. Serialization operators to QDataStream to both classes.
4. Tests for simpleresourcetest


Diffs (updated)
-----

  nepomuk/services/storage/lib/simpleresource.h c6c3b04 
  nepomuk/services/storage/lib/simpleresource.cpp 3d529bb 
  nepomuk/services/storage/lib/simpleresourcegraph.h 6a3a0ee 
  nepomuk/services/storage/lib/simpleresourcegraph.cpp 419a949 
  nepomuk/services/storage/test/CMakeLists.txt f8d00de 
  nepomuk/services/storage/test/simpleresourceclassestest.h PRE-CREATION 
  nepomuk/services/storage/test/simpleresourceclassestest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101856/diff


Testing
-------

Provide tests for this operations. Currently failing addGraph test, because of SimpleResource::addProperties behaviour. But may be it is intended, then I will rewrite test case.


Thanks,

Artem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110707/224598c3/attachment.htm