[Nepomuk] Review Request: PropertyChanged Signal in the Resource Watcher

Vishesh Handa handa.vish at gmail.com
Fri Dec 23 16:12:43 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103522/
-----------------------------------------------------------

Review request for Nepomuk, Martin Klapetek and Sebastian Trueg.


Description
-------

Implemented the propertyChanged signal in the Resource Watcher.

DBus is retarded. It refuses to work if I sent the changed list as a variant/variant list. It works if I send it as a string list though.


Diffs
-----

  nepomuk/interfaces/org.kde.nepomuk.ResourceWatcherConnection.xml 8b175bc 
  nepomuk/services/storage/datamanagementmodel.h 2660837 
  nepomuk/services/storage/datamanagementmodel.cpp b4e38aa 
  nepomuk/services/storage/lib/resourcewatcher.h ac4425d 
  nepomuk/services/storage/lib/resourcewatcher.cpp f6fc93c 
  nepomuk/services/storage/resourcewatcherconnection.h 6100fb4 
  nepomuk/services/storage/resourcewatchermanager.h 707ddab 
  nepomuk/services/storage/resourcewatchermanager.cpp 6276254 

Diff: http://git.reviewboard.kde.org/r/103522/diff/diff


Testing
-------

Works perfectly. Tried monitoring NAO:numericRating


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20111223/755bc864/attachment.html>


More information about the Nepomuk mailing list