[Nepomuk] Review Request: Add nfo:Audio type to riff analyzer

[Sebastian Trueg]

> On None, Sebastian Trueg wrote:
> > plugins/eventplugins/riffeventanalyzer.cpp, line 370
> > <http://git.reviewboard.kde.org/r/102336/diff/2/?file=31988#file31988line370>
> >
> >     Will inAudioStream already be defined properly at this point?

Actually I think adding the type in processStrh() makes most sense. Then you are sure about the type.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102336/#review5756
-----------------------------------------------------------


On Aug. 16, 2011, 4:45 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102336/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2011, 4:45 p.m.)
> 
> 
> Review request for Nepomuk, Strigi, Jos van den Oever, and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Add the required type. I'm not sure if I should be adding nfo:Audio or nfo:MusicPiece.
> 
> 
> Diffs
> -----
> 
>   lib/endanalyzers/id3endanalyzer.cpp 5060e1b 
>   plugins/eventplugins/riffeventanalyzer.cpp 69aa927 
> 
> Diff: http://git.reviewboard.kde.org/r/102336/diff
> 
> 
> Testing
> -------
> 
> Works fine, and the files are getting indexed by Nepomuk as they have the correct type.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110826/71071d1a/attachment.html>