[Nepomuk] Review Request: Added the ability to see currently indexed file and ability to pause or resume strigi in status widget

[Sebastian Trueg]

> On Aug. 24, 2011, 10:03 a.m., Sebastian Trueg wrote:
> >
> 
> Smit Shah wrote:
>     prevStatus is useful , i mean if statusString is same as prevStatus , we shouldn't setText in the first place , i know the same thing can be achieved by comparing with m_labelIndexing->text() but i thought using QString variable might be faster than calling that method.

prevStatus would be useful if you would use it properly. Please read your code and my comments again and concentrate a bit. I commented all the problematic code lines.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102301/#review5976
-----------------------------------------------------------


On Aug. 24, 2011, 9:25 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102301/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2011, 9:25 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Now you can pause or resume strigi and see the currently indexed file.
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/systray.cpp 9e058f8 
>   nepomuk/kcm/CMakeLists.txt 313205a 
>   nepomuk/kcm/nepomukserverkcm.cpp b7dcab9 
>   nepomuk/kcm/statuswidget.h 0440745 
>   nepomuk/kcm/statuswidget.cpp 4798d7f 
>   nepomuk/kcm/statuswidget.ui 359ec6e 
> 
> Diff: http://git.reviewboard.kde.org/r/102301/diff
> 
> 
> Testing
> -------
> 
> paused and resume couple of times and it works perfectly.
> 
> 
> Screenshots
> -----------
> 
> See
>   http://git.reviewboard.kde.org/r/102301/s/223/
> see again
>   http://git.reviewboard.kde.org/r/102301/s/224/
> with current status
>   http://git.reviewboard.kde.org/r/102301/s/226/
> 
>   http://git.reviewboard.kde.org/r/102301/s/227/
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110824/8d70d4c5/attachment.html>