[Nepomuk] Review Request: Added the ability to see currently indexed file and ability to pause or resume strigi in status widget

Sebastian Trueg sebastian at trueg.de
Wed Aug 24 10:03:47 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102301/#review5976
-----------------------------------------------------------



nepomuk/kcm/statuswidget.cpp
<http://git.reviewboard.kde.org/r/102301/#comment5285>

    What is this used for?



nepomuk/kcm/statuswidget.cpp
<http://git.reviewboard.kde.org/r/102301/#comment5286>

    This is the same as 
    
    if(!statusString.isEmpty())
    
    I suppose you want to compare to the current text which would be m_labelIndexing->text()



nepomuk/kcm/statuswidget.cpp
<http://git.reviewboard.kde.org/r/102301/#comment5287>

    Pointless assignment since it is never used.


- Sebastian


On Aug. 24, 2011, 9:25 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102301/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2011, 9:25 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Now you can pause or resume strigi and see the currently indexed file.
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/systray.cpp 9e058f8 
>   nepomuk/kcm/CMakeLists.txt 313205a 
>   nepomuk/kcm/nepomukserverkcm.cpp b7dcab9 
>   nepomuk/kcm/statuswidget.h 0440745 
>   nepomuk/kcm/statuswidget.cpp 4798d7f 
>   nepomuk/kcm/statuswidget.ui 359ec6e 
> 
> Diff: http://git.reviewboard.kde.org/r/102301/diff
> 
> 
> Testing
> -------
> 
> paused and resume couple of times and it works perfectly.
> 
> 
> Screenshots
> -----------
> 
> See
>   http://git.reviewboard.kde.org/r/102301/s/223/
> see again
>   http://git.reviewboard.kde.org/r/102301/s/224/
> with current status
>   http://git.reviewboard.kde.org/r/102301/s/226/
> 
>   http://git.reviewboard.kde.org/r/102301/s/227/
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110824/d52efdf4/attachment-0001.html>


More information about the Nepomuk mailing list