[Nepomuk] Review Request: Added the ability to see currently indexed file and ability to pause or resume strigi in status widget

Smit Shah who828 at gmail.com
Sat Aug 20 07:08:27 UTC 2011



> On Aug. 19, 2011, 11:27 a.m., Sebastian Trueg wrote:
> > nepomuk/kcm/statuswidget.cpp, line 182
> > <http://git.reviewboard.kde.org/r/102301/diff/5/?file=32035#file32035line182>
> >
> >     Code duplication with the badly names slotToggle. Instead call the toggle slot here.
> 
> Smit Shah wrote:
>     Understood.

Okay sorry i just checked this right now and i realized i can't put slotToggel here since it has following code,
if( m_fileIndexerService->isSuspended()) {
        m_fileIndexerService->resume();
        m_suspendResumeButton->setText(i18nc("Suspends Strigi","Suspend"));
    }

it will resume the service as well or vice versa , and as the statusChanges again (which happens every second when strigi is indexing) the widget will crash so i do need this code there.


- Smit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102301/#review5824
-----------------------------------------------------------


On Aug. 17, 2011, 1:32 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102301/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 1:32 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Now you can pause or resume strigi and see the currently indexed file.
> 
> 
> Diffs
> -----
> 
>   nepomuk/controller/systray.cpp 6cf6bc9 
>   nepomuk/kcm/CMakeLists.txt 561d48a 
>   nepomuk/kcm/nepomukserverkcm.cpp 74031b7 
>   nepomuk/kcm/statuswidget.h 0440745 
>   nepomuk/kcm/statuswidget.cpp 4798d7f 
>   nepomuk/kcm/statuswidget.ui 359ec6e 
> 
> Diff: http://git.reviewboard.kde.org/r/102301/diff
> 
> 
> Testing
> -------
> 
> paused and resume couple of times and it works perfectly.
> 
> 
> Screenshots
> -----------
> 
> See
>   http://git.reviewboard.kde.org/r/102301/s/223/
> see again
>   http://git.reviewboard.kde.org/r/102301/s/224/
> with current status
>   http://git.reviewboard.kde.org/r/102301/s/226/
> 
>   http://git.reviewboard.kde.org/r/102301/s/227/
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110820/ee7f0a53/attachment-0001.html>


More information about the Nepomuk mailing list