[Nepomuk] Review Request: Thread Safety in the IndexScheduler

Sebastian Trueg sebastian at trueg.de
Wed Aug 10 11:57:34 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102251/#review5587
-----------------------------------------------------------

Ship it!


- Sebastian


On Aug. 10, 2011, 11:24 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102251/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 11:24 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Many of the variables need to be accessed in IndexScheduler need to be protected with a mutex.
> 
> I think it's better to use multiple mutexes instead of one.
> 
> 
> This addresses bug 279347.
>     http://bugs.kde.org/show_bug.cgi?id=279347
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/strigi/indexscheduler.h 4c83d04 
>   nepomuk/services/strigi/indexscheduler.cpp 7fd4dcb 
> 
> Diff: http://git.reviewboard.kde.org/r/102251/diff
> 
> 
> Testing
> -------
> 
> Nope. Don't know how to test this.
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110810/a1d5325b/attachment-0001.html>


More information about the Nepomuk mailing list