[Nepomuk] Review Request: New GraphMaintainer class which removes empty graphs

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102214/#review5506
-----------------------------------------------------------



nepomuk/services/storage/graphmaintainer.cpp
<http://git.reviewboard.kde.org/r/102214/#comment4932>

    Mutex perhaps?



nepomuk/services/storage/graphmaintainer.cpp
<http://git.reviewboard.kde.org/r/102214/#comment4933>

    Mutex?



nepomuk/services/storage/graphmaintainer.cpp
<http://git.reviewboard.kde.org/r/102214/#comment4934>

    Mutex?



nepomuk/services/storage/graphmaintainer.cpp
<http://git.reviewboard.kde.org/r/102214/#comment4935>

    It's generally not advised to block a thread like this, it would be better to wrap the code in a function and call that after certain intervals using a timer.
    
    But that is generally done so that we can have an event loop in the thread. Do we really need an event loop over here?


- Vishesh


On Aug. 4, 2011, 2:43 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102214/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2011, 2:43 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> The new GraphMaintainer is created at startup and will slowly remove empty graphs which are left over from the pre-DMS days. It uses a delay between each removal operation to not impose on the user's work at all. Thus, it takes forever to remove the graphs but that is no big deal.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/storage/CMakeLists.txt 75f6fd8 
>   nepomuk/services/storage/graphmaintainer.h PRE-CREATION 
>   nepomuk/services/storage/graphmaintainer.cpp PRE-CREATION 
>   nepomuk/services/storage/repository.cpp ce0d385 
> 
> Diff: http://git.reviewboard.kde.org/r/102214/diff
> 
> 
> Testing
> -------
> 
> Tested manually: all empty graphs removed.
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110808/84fd5678/attachment-0001.html>