[Nepomuk] Review Request: Fixed performer sub-resource creation for ID3v1 tags

Vishesh Handa handa.vish at gmail.com
Sat Aug 6 11:57:00 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102229/#review5431
-----------------------------------------------------------

Ship it!


I did the same thing, but I thought nco:creator wasn't right, and wanted to discuss it.

This is fairly trivial.

- Vishesh


On Aug. 5, 2011, 8:36 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102229/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 8:36 p.m.)
> 
> 
> Review request for Nepomuk and Strigi.
> 
> 
> Summary
> -------
> 
> The title says it all: the analyser still creates nco:creator properties with a string range. This patch changes that to nmm:performer with a nco:Contact range.
> 
> 
> Diffs
> -----
> 
>   lib/endanalyzers/id3endanalyzer.cpp 2a5d446 
> 
> Diff: http://git.reviewboard.kde.org/r/102229/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110806/dd758d30/attachment.html>


More information about the Nepomuk mailing list