[Nepomuk] Review Request: Implementing Queue in Writebackservice

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102225/#review5415
-----------------------------------------------------------



nepomuk/services/writeback/service/writebackservice.cpp
<http://git.reviewboard.kde.org/r/102225/#comment4883>

    It should be easy to see what is wrong here. You never enqueue the resource if there is no current job.
    The task is to enqueue and then call startWriteback()



nepomuk/services/writeback/service/writebackservice.cpp
<http://git.reviewboard.kde.org/r/102225/#comment4884>

    First set m_currentjob to 0. Although it would be cleaner to have a dedicated slot slotJobFinished() which would then set m_currentjob to 0 and afterwards cann startWriteback().


- Sebastian


On Aug. 5, 2011, 5:18 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102225/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 5:18 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> I have been bit busy with traveling to berlin for DS , so i am posting the review request bit late , this one is for the queue in writebackservice and i will soon post the review request for passing kdelistservice.
> 
> 
> Diffs
> -----
> 
>   nepomuk/services/writeback/service/writebackservice.h db6e83a 
>   nepomuk/services/writeback/service/writebackservice.cpp 673aa59 
> 
> Diff: http://git.reviewboard.kde.org/r/102225/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110805/f8e662b2/attachment.html>