[Nepomuk] Re: Review Request: Auto Indent Queries

Vishesh Handa handa.vish at gmail.com
Wed Apr 13 14:56:54 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101103/#review2611
-----------------------------------------------------------


These haven't been fixed -
1. Statements which end with a '.', but there is no space before the .
2. The character '@' is used for the langauge tag in literals, prefixes, and uris ( <mailto:name at host.com> ). If anyone of them are present the indentation would get screwed up.

Again, I haven't really tested it. I'll test it tonight.

- Vishesh


On April 13, 2011, 10:49 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101103/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 10:49 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This patch adds one feature,
> 
>  Adds a button to auto indent the query.
> 
> 
> Diffs
> -----
> 
>   mainwindow.h ebf4dd5 
>   mainwindow.cpp d9cd450 
>   nepomukshellui.rc e4d59c2 
>   resourcequerywidget.h 22224fc 
>   resourcequerywidget.cpp 757674f 
> 
> Diff: http://git.reviewboard.kde.org/r/101103/diff
> 
> 
> Testing
> -------
> 
> i have tested both the features on number of queries/files and it works perfectly over here.
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110413/2e27492a/attachment.htm 


More information about the Nepomuk mailing list