[Nepomuk] Re: Review Request: Auto Indent Queries and Opening/Saving Query Buttons

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101103/#review2580
-----------------------------------------------------------


As you can see most of my comments refer to code formatting. That is a good sign. :) But Vishesh is right, please make it two review requests.


mainwindow.cpp
<http://git.reviewboard.kde.org/r/101103/#comment2259>

    The "open-new" icon does not exist AFAIK. Please check the oxygen-icons to find a suitable one.



nepomukshell.desktop
<http://git.reviewboard.kde.org/r/101103/#comment2253>

    Why this line?



resourcequerywidget.h
<http://git.reviewboard.kde.org/r/101103/#comment2254>

    Please fix whitespace.



resourcequerywidget.cpp
<http://git.reviewboard.kde.org/r/101103/#comment2255>

    whitespace.



resourcequerywidget.cpp
<http://git.reviewboard.kde.org/r/101103/#comment2257>

    whitespace.



resourcequerywidget.cpp
<http://git.reviewboard.kde.org/r/101103/#comment2256>

    Please use code indentation like so: 
    
    while(...) {
       // do stuff
    }


- Sebastian


On April 12, 2011, 11:45 a.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101103/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 11:45 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> This patch adds two features,
> 
> 1. Adds a button to auto indent the query.
> 
> 2. Adds an option to open/save queries into a file.
> 
> 
> Diffs
> -----
> 
>   mainwindow.h ebf4dd5 
>   mainwindow.cpp d9cd450 
>   nepomukshell.desktop 92026ae 
>   nepomukshellui.rc e4d59c2 
>   resourcequerywidget.h 22224fc 
>   resourcequerywidget.cpp 757674f 
> 
> Diff: http://git.reviewboard.kde.org/r/101103/diff
> 
> 
> Testing
> -------
> 
> i have tested both the features on number of queries/files and it works perfectly over here.
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110412/0d10ee30/attachment-0001.htm