[Nepomuk] Re: Review Request: Support for Raptor2

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101069/#review2564
-----------------------------------------------------------



parsers/raptor/raptorparser.h
<http://git.reviewboard.kde.org/r/101069/#comment2237>

    Please revert your space change here.



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2238>

    Is there an empty line after the method declaration?



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2239>

    Is this a superfluous empty line?



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2240>

    This empty line is useless.



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2241>

    What about SerializationTrig?



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2242>

    Why do you need 2 RaptorInitHelper instances? The second one is enough.



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2243>

    Is there no graph handler in raptor2 anymore? How are context/graph nodes handled then?



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2244>

    Please keep this empty line. "Policy" in Soprano is 2 empty lines between methods.


- Sebastian


On April 9, 2011, 8:21 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101069/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 8:21 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Adding support for Raptor2 for Soprano, currently i have ported parser to Raptor2 soon i will port serializers as well.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindRaptor.cmake 6347647 
>   parsers/raptor/CMakeLists.txt 2adf527 
>   parsers/raptor/raptor-config.h.cmake dc35028 
>   parsers/raptor/raptorparser.h e6a7f99 
>   parsers/raptor/raptorparser.cpp 0aabb73 
> 
> Diff: http://git.reviewboard.kde.org/r/101069/diff
> 
> 
> Testing
> -------
> 
> I ran the test cases provided with Soprano it passed all of them.
> 
> Results : http://paste.kde.org/9734/ 
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110411/590e699e/attachment.htm