[Nepomuk] Re: Review Request: Support for Raptor2

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101069/#review2521
-----------------------------------------------------------



parsers/raptor/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101069/#comment2214>

    Please use the patch I provided instead. This now links to both raptor1 and raptor2 which could lead to crashes.
    
    Also I just remembered that you can remove the configure_file line which creates raptor_config.h as well as the raptor_config.h.cmake which is the template.
    
    Also all the cmake code necessary to check if trig is supported can be removed.



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2215>

    Please add the missing newline before the RaptorInitHelper



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2216>

    We need to test is this is still valid with raptor2.



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2217>

    Please add missing newline.



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2218>

    There is no need for the HAVE_TRIG check anymore.
    1. Raptor2 always has support for it.
    2. Since we removed the raptor_config.h the var would never be defined anyway.


- Sebastian


On April 9, 2011, 7:08 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101069/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 7:08 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Adding support for Raptor2 for Soprano, currently i have ported parser to Raptor2 soon i will port serializers as well.
> 
> 
> Diffs
> -----
> 
>   parsers/raptor/CMakeLists.txt 2adf527 
>   parsers/raptor/raptorparser.h e6a7f99 
>   parsers/raptor/raptorparser.cpp 0aabb73 
> 
> Diff: http://git.reviewboard.kde.org/r/101069/diff
> 
> 
> Testing
> -------
> 
> I ran the test cases provided with Soprano it passed all of them.
> 
> Results : http://paste.kde.org/9734/ 
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110409/5eeea55b/attachment-0001.htm