[Nepomuk] Re: Review Request: Support for Raptor2

Vishesh Handa handa.vish at gmail.com
Sat Apr 9 19:56:36 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101069/#review2519
-----------------------------------------------------------



parsers/raptor/raptorparser.h
<http://git.reviewboard.kde.org/r/101069/#comment2213>

    Please fix the code formatting



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2211>

    Please rename it to something more descriptive than "check". Maybe raptor?



parsers/raptor/raptorparser.cpp
<http://git.reviewboard.kde.org/r/101069/#comment2212>

    The code formatting is wrong


- Vishesh


On April 9, 2011, 5:31 p.m., Smit Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101069/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 5:31 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Summary
> -------
> 
> Adding support for Raptor2 for Soprano, currently i have ported parser to Raptor2 soon i will port serializers as well.
> 
> 
> Diffs
> -----
> 
>   parsers/raptor/CMakeLists.txt 2adf527 
>   parsers/raptor/raptorparser.h e6a7f99 
>   parsers/raptor/raptorparser.cpp 0aabb73 
> 
> Diff: http://git.reviewboard.kde.org/r/101069/diff
> 
> 
> Testing
> -------
> 
> I ran the test cases provided with Soprano it passed all of them.
> 
> Results : http://paste.kde.org/9734/ 
> 
> 
> Thanks,
> 
> Smit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/nepomuk/attachments/20110409/05e8e28d/attachment.htm 


More information about the Nepomuk mailing list