[Nepomuk] [PATCH] Strigiservice Initial Run timing bug.

[Sebastian Trüg]

Hi Vishesh,

very nice. One question:
Why do you time the paused state instead of the indexing? Isn't it
easier to understand if you time the indexing and when paused add the
elapsed time to m_initialIndexTime?

And I just realized another bug in the service: the eventmonitor does
not get informed when the indexing is resumed by another party (for
example manually by the user). In that case the timing is wrong again.

Cheers,
Sebastian

On 04/20/2010 10:01 PM, Vishesh Handa wrote:
> Hi
> 
> Currently the initial indexing timing is buggy. The timer isn't paused
> when the indexing is paused. This patch fixes the issue.
> 
> I've done a minor amount of refactoring by adding two private slots -
> pauseIndexing and resumeIndexing. Should I have prefixed them with slot?
> I've refactored the code cause it makes it easier to read, and the TODO
> given (Add actions to the initial indexing notification) is now easily
> doable.
> 
> Now to the part I suck at - Testing. How in the world am I supposed to
> test it? It tried to change the location of the virtuoso repository
> (nepomukserverrc file) to a pen drive which didn't have adequate space,
> but that didn't really work. I started getting errors like -
> [/home/vishesh/kde/bin/nepomukservicestub]
> "/home/vishesh/kde/bin/nepomukservicestub(5372)" Error in thread
> 3052354416 : "SQLExecDirect failed on query 'sparql  ask where { {
> <nepomuk:/ctx/7d689871-f944-460b-b0bf-75dbd444766c> ?p1 ?o1 . } UNION {
> ?s2 <nepomuk:/ctx/7d689871-f944-460b-b0bf-75dbd444766c> ?o2 . } UNION {
> ?s3 ?p3 <nepomuk:/ctx/7d689871-f944-460b-b0bf-75dbd444766c> . } UNION {
> graph <nepomuk:/ctx/7d689871-f944-460b-b0bf-75dbd444766c> { ?s4 ?4 ?o4 .
> } . } }' (iODBC Error: [OpenLink][Virtuoso iODBC Driver][Virtuoso
> Server]SR174: Log out of disk : while writing new IRI_ID allocation to
> log file)"
> 
> And I didn't get any notification saying there wasn't adequate space. :-/
> 
> Could somebody test it out by draining their laptop battery? I have no
> idea how I can emulate a battery on my desktop.
> 
> Thanks
> 
> - Vishesh Handa
> 
> 
> 
> _______________________________________________
> Nepomuk mailing list
> Nepomuk at kde.org
> https://mail.kde.org/mailman/listinfo/nepomuk