[neon/extras/krename/Neon/release] debian: drop %i from desktop file (#1010744)

Pino Toscano null at kde.org
Wed Sep 4 10:35:07 BST 2024


Git commit 16fcadfa7850cc3191d72ac537159fc92b1f7e67 by Pino Toscano.
Committed on 14/08/2022 at 07:13.
Pushed by jriddell into branch 'Neon/release'.

drop %i from desktop file (#1010744)

backport upstream commit 9e21688a83e5683ad77fca3be91afe351552287b

M  +3    -0    debian/changelog
A  +1    -0    debian/patches/series
A  +31   -0    debian/patches/upstream_Drop-i-from-desktop-file.patch

https://invent.kde.org/neon/extras/krename/-/commit/16fcadfa7850cc3191d72ac537159fc92b1f7e67

diff --git a/debian/changelog b/debian/changelog
index 932192b..dec3369 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,9 @@ krename (5.0.1-2) UNRELEASED; urgency=medium
   * Bump Standards-Version to 4.6.1, no changes required.
   * Remove inactive Uploaders, adding myself as one to avoid leaving the source
     with no human maintainers.
+  * Backport upstream commit 9e21688a83e5683ad77fca3be91afe351552287b to drop
+    %i from desktop file, fixing the launch of krename from menus on Wayland;
+    patch upstream_Drop-i-from-desktop-file.patch. (Closes: #1010744)
 
  -- Debian KDE Extras Team <pkg-kde-extras at lists.alioth.debian.org>  Sun, 14 Aug 2022 09:02:36 +0200
 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..703eeb3
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+upstream_Drop-i-from-desktop-file.patch
diff --git a/debian/patches/upstream_Drop-i-from-desktop-file.patch b/debian/patches/upstream_Drop-i-from-desktop-file.patch
new file mode 100644
index 0000000..dec8714
--- /dev/null
+++ b/debian/patches/upstream_Drop-i-from-desktop-file.patch
@@ -0,0 +1,31 @@
+From 9e21688a83e5683ad77fca3be91afe351552287b Mon Sep 17 00:00:00 2001
+From: Heiko Becker <heirecka at exherbo.org>
+Date: Thu, 8 Oct 2020 17:57:27 +0200
+Subject: [PATCH] Drop %i from desktop file
+
+%i is expanded to --icon <icon>,  but Qt recognizes this option only on
+X11/xcb, not on Wayland. Therefore krename failed to start via desktop file
+on Wayland. Dropping %i has no effect even on X11/xcb because we call
+QApplication::setWindowIcon in main().
+
+BUG: 427207
+FIXED-IN: 5.0.2
+---
+ src/org.kde.krename.desktop | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/org.kde.krename.desktop b/src/org.kde.krename.desktop
+index 5584af9..f5a8739 100644
+--- a/src/org.kde.krename.desktop
++++ b/src/org.kde.krename.desktop
+@@ -1,6 +1,6 @@
+ [Desktop Entry]
+ Type=Application
+-Exec=krename -qwindowtitle "%c" %i %U
++Exec=krename -qwindowtitle "%c" %U
+ Icon=krename
+ Comment=A batch renamer
+ Comment[ca]=Un canviador de noms de fitxers per lots
+-- 
+2.35.1
+



More information about the Neon-commits mailing list