[neon/qt6/qt6-webengine/Neon/unstable] debian: Makefile sh uses . instead of source

Carlos De Maine null at kde.org
Wed Sep 6 00:11:38 BST 2023


Git commit ab6039db94c2644e5bc577b4a5894643abf4cb00 by Carlos De Maine.
Committed on 06/09/2023 at 01:11.
Pushed by carlosdem into branch 'Neon/unstable'.

Makefile sh uses . instead of source

M  +3    -10   debian/rules

https://invent.kde.org/neon/qt6/qt6-webengine/-/commit/ab6039db94c2644e5bc577b4a5894643abf4cb00

diff --git a/debian/rules b/debian/rules
index 037713c..bab3e75 100755
--- a/debian/rules
+++ b/debian/rules
@@ -41,16 +41,9 @@ override_dh_auto_clean:
 		rm -f $(CURDIR)/$${fname}; \
 	done
 
-# 	define run_npm =
-# 		# init nvm and thus npm && # install needed nodejs deps with npm
-# 		source /etc/profile.d/nvm-profile.sh
-# 		npm install pako
-# 		npm install rollup-plugin-terser
-# 		npm install yargs
-# 	endef
-# 	run_npm: ; $(value run_npm)
-# 	.ONESHELL:
-	source /root/.nvm/nvm.sh && \ # This loads nvm
+	# this init's nvm and installs the required node deps with npm in one continous go as 
+	# Makefile sh doesn't add bashism's and executes each line in a new shell thus losing all the env variables
+	. /root/.nvm/nvm.sh && \ 
 	npm install pako && \
 	npm install rollup-plugin-terser && \
 	npm install yargs


More information about the Neon-commits mailing list