[neon/extras/ktechlab] debian: fix the selection of files as properties

[Pino Toscano]

Git commit 18b8eb26e81da36bda148a58252608da2090b4cb by Pino Toscano.
Committed on 01/11/2020 at 08:58.
Pushed by jriddell into branch 'master'.

fix the selection of files as properties

backport upstream commit e303b80756770069526ef16e0a81d343c2e9ca13

M  +3    -0    debian/changelog
M  +1    -0    debian/patches/series
A  +24   -0    debian/patches/upstream_Fix-selecting-files-as-properties.patch

https://invent.kde.org/neon/extras/ktechlab/commit/18b8eb26e81da36bda148a58252608da2090b4cb

diff --git a/debian/changelog b/debian/changelog
index 2a8205f..9af7ca8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,9 @@ ktechlab (0.50.0-2) UNRELEASED; urgency=medium
   * Backport upstream commit a24dc9737462662390c9b0f37ce66774283df69c to fix
     lifetime of intermediate temporary files; patch
     upstream_process-chain-keep-temporary-files-live-longer.patch.
+  * Backport upstream commit e303b80756770069526ef16e0a81d343c2e9ca13 to fix
+    the selection of files as properties; patch
+    upstream_Fix-selecting-files-as-properties.patch.
 
  -- Debian KDE Extras Team <pkg-kde-extras at lists.alioth.debian.org>  Thu, 29 Oct 2020 21:49:14 +0100
 
diff --git a/debian/patches/series b/debian/patches/series
index 683326b..8d82e81 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 upstream_process-chain-keep-temporary-files-live-longer.patch
+upstream_Fix-selecting-files-as-properties.patch
diff --git a/debian/patches/upstream_Fix-selecting-files-as-properties.patch b/debian/patches/upstream_Fix-selecting-files-as-properties.patch
new file mode 100644
index 0000000..dd64fea
--- /dev/null
+++ b/debian/patches/upstream_Fix-selecting-files-as-properties.patch
@@ -0,0 +1,24 @@
+From e303b80756770069526ef16e0a81d343c2e9ca13 Mon Sep 17 00:00:00 2001
+From: Pino Toscano <pino at kde.org>
+Date: Fri, 30 Oct 2020 17:29:48 +0100
+Subject: [PATCH] Fix selecting files as properties
+
+When the file selector is cancelled the returned path is empty, so fix
+the check.
+
+Fixes commit d1fb957dd215e57e0232ff6061b2a5c37b0f32aa
+---
+ src/gui/itemeditor/propertyeditorfile.cpp | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/src/gui/itemeditor/propertyeditorfile.cpp
++++ b/src/gui/itemeditor/propertyeditorfile.cpp
+@@ -52,7 +52,7 @@ void PropertyEditorFile::selectFile()
+ {
+     const QString filePath = QFileDialog::getOpenFileName(this, i18n("Choose File"), QString(), m_property->filter());
+     qDebug() << Q_FUNC_INFO << "got QString: " << filePath;
+-    if (!filePath.isEmpty()) {
++    if (filePath.isEmpty()) {
+         qDebug() << Q_FUNC_INFO << "url is not valid, not setting it";
+ 		return;
+     }