[neon/extras/kstars/Neon/release] debian: drop useless xterm test

[Pino Toscano]

Git commit 82660fe9a3c50d31469e5ada06dc63995b20076e by Pino Toscano.
Committed on 12/12/2021 at 10:24.
Pushed by jriddell into branch 'Neon/release'.

drop useless xterm test

backport upstream commit 6782a28d34d354ba1a73f173afeffbe0157bea15

M  +2    -0    debian/changelog
M  +1    -0    debian/patches/series
A  +29   -0    debian/patches/upstream_tests-remove-useless-xterm-test.patch

https://invent.kde.org/neon/extras/kstars/commit/82660fe9a3c50d31469e5ada06dc63995b20076e

diff --git a/debian/changelog b/debian/changelog
index 606e19f..c51d41c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,8 @@ kstars (5:3.5.6-2) UNRELEASED; urgency=medium
   * Set field Upstream-Contact in debian/copyright.
   * Remove obsolete field Contact from debian/upstream/metadata (already present
     in machine-readable debian/copyright).
+  * Backport upstream commit 6782a28d34d354ba1a73f173afeffbe0157bea15 to drop
+    an useless xterm test; patch upstream_tests-remove-useless-xterm-test.patch.
 
  -- Debian KDE Extras Team <pkg-kde-extras at lists.alioth.debian.org>  Sun, 12 Dec 2021 09:35:28 +0100
 
diff --git a/debian/patches/series b/debian/patches/series
index 8cbadc0..466f7f7 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
+upstream_tests-remove-useless-xterm-test.patch
 skip-skypoint-test.diff
 skip-installed-tests.diff
diff --git a/debian/patches/upstream_tests-remove-useless-xterm-test.patch b/debian/patches/upstream_tests-remove-useless-xterm-test.patch
new file mode 100644
index 0000000..a3d8c53
--- /dev/null
+++ b/debian/patches/upstream_tests-remove-useless-xterm-test.patch
@@ -0,0 +1,29 @@
+From 6782a28d34d354ba1a73f173afeffbe0157bea15 Mon Sep 17 00:00:00 2001
+From: Pino Toscano <pino at kde.org>
+Date: Sun, 12 Dec 2021 11:20:08 +0100
+Subject: [PATCH] tests: remove useless xterm test
+
+Running xterm as own test makes no sense, and it is completely out of
+scope for kstars; commit d0a8183ece20e9f46baddd73926c44e9003bb6e8 added
+it without explanation, so assume it was some experiment that slipped
+in.
+---
+ Tests/kstars_ui/CMakeLists.txt | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/Tests/kstars_ui/CMakeLists.txt b/Tests/kstars_ui/CMakeLists.txt
+index 40a6e7d1a..09df6422c 100644
+--- a/Tests/kstars_ui/CMakeLists.txt
++++ b/Tests/kstars_ui/CMakeLists.txt
+@@ -31,8 +31,6 @@ qt5_add_dbus_adaptor(KSTARS_UI_MOCK_SRC org.kde.kstars.MockEkos.MockAlign.xml mo
+ qt5_add_dbus_adaptor(KSTARS_UI_MOCK_SRC org.kde.kstars.MockEkos.MockGuide.xml mockmodules.h Ekos::MockGuide)
+ qt5_add_dbus_adaptor(KSTARS_UI_MOCK_SRC org.kde.kstars.MockEkos.xml mockmodules.h Ekos::MockEkos)
+ 
+-ADD_TEST(ui_xterm xterm)
+-
+ # FIXME: this particular test crashes when done on the EGLFS platform
+ # Disabling until we find the reason, other tests do cover this scenario
+ 
+-- 
+2.33.0
+