Review Request: QMediaPlayer using Android's MediaPlayer and MediaMetadataRetriever

[Gabi Julien]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105051/
-----------------------------------------------------------

(Updated May 28, 2012, 2:58 p.m.)


Review request for Necessitas.


Changes
-------

Review: Added contact information


Description
-------

As discussed on the mailing list[1], this is an implementation of QMediaPlayer using Android's MediaPlayer and MediaMetadataRetriever classes. This patch is only the android-lighthouse part. Another patch on qt-mobility is needed.

[1] http://mail.kde.org/pipermail/necessitas-devel/2012-May/000916.html


Diffs (updated)
-----

  src/android/jar/src/org/kde/necessitas/mobile/QtMediaPlayer.java 292e8cc 
  src/android/jar/src/org/kde/necessitas/mobile/QtMediaPlayerController.java PRE-CREATION 
  src/android/jar_14/src/org/kde/necessitas/mobile/QtMediaMetadataRetriever.java PRE-CREATION 
  src/android/jar_14/src/org/kde/necessitas/mobile/QtMediaMetadataRetrieverController.java PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105051/diff/


Testing
-------

Using Asus's Transformer Prime TF 201
1. 1080p h264 video on Android 4.0.3.
2. mp3 music without surfaces.
3. Various tests involving volume, seeking, duration,... using the QMediaPlayer API.

My tests on Android 2.3.1 failed so far because a second hardware accelerated surface is needed. Also, the MediaMetadataRetriever is not available before API 10. The good news is that music playback should still work.


Thanks,

Gabi Julien

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20120528/eaa08c53/attachment.html>