Review Request: QMediaPlayer using Android's MediaPlayer and MediaMetadataRetriever

[Gabi Julien]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105052/
-----------------------------------------------------------

(Updated May 28, 2012, 2:57 p.m.)


Review request for Necessitas.


Changes
-------

Review: Added contact information


Description
-------

As discussed on the mailing list[1], this is an implementation of QMediaPlayer using Android's MediaPlayer and MediaMetadataRetriever classes. This patch is only the qt-mobility part. Another patch on android-lighthouse is needed.

[1] http://mail.kde.org/pipermail/necessitas-devel/2012-May/000916.html


Diffs (updated)
-----

  plugins/multimedia/android/mediaplayer/jnienvcontext.h PRE-CREATION 
  plugins/multimedia/android/mediaplayer/jnienvcontext.cpp PRE-CREATION 
  plugins/multimedia/android/mediaplayer/jnimanager.h PRE-CREATION 
  plugins/multimedia/android/mediaplayer/jnimanager.cpp PRE-CREATION 
  plugins/multimedia/android/mediaplayer/mediaPlayerJNI.h a77cec4 
  plugins/multimedia/android/mediaplayer/mediaPlayerJNI.cpp 110a6ac 
  plugins/multimedia/android/mediaplayer/mediaplayer.pro 9b8d64d 
  plugins/multimedia/android/mediaplayer/qandroidmetadatacontrol.cpp 6dd2f4a 
  plugins/multimedia/android/mediaplayer/qandroidplayercontrol.cpp a519ece 
  plugins/multimedia/android/mediaplayer/qandroidplayersession.h 7efffba 
  plugins/multimedia/android/mediaplayer/qandroidplayersession.cpp 612ee2d 
  plugins/multimedia/android/mediaplayer/qandroidvideothread.h fb4660d 
  plugins/multimedia/android/mediaplayer/qandroidvideothread.cpp fb7f0a1 
  plugins/multimedia/android/mediaplayer/qandroidvideowidget.cpp cce50a4 
  plugins/multimedia/android/mediaplayer/qtmediametadataretrieverjni.h PRE-CREATION 
  plugins/multimedia/android/mediaplayer/qtmediametadataretrieverjni.cpp PRE-CREATION 
  plugins/multimedia/android/mediaplayer/qtmediaplayerjni.h PRE-CREATION 
  plugins/multimedia/android/mediaplayer/qtmediaplayerjni.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105052/diff/


Testing
-------

Using Asus's Transformer Prime TF 201
1. 1080p h264 video on Android 4.0.3.
2. mp3 music without surfaces.
3. Various tests involving volume, seeking, duration,... using the QMediaPlayer API.

My tests on Android 2.3.1 failed so far because a second hardware accelerated surface is needed. Also, the MediaMetadataRetriever is not available before API 10. The good news is that music playback should still work.


Thanks,

Gabi Julien

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20120528/8822db62/attachment.html>