More patches

Daniel Teske daniel.teske at nokia.com
Thu Sep 8 18:41:19 UTC 2011


Hi,

another round of small patches

0001:
  That patch removes a warning for me. I'm a little bit unsure where that
  zorder line comes from, or what the effect is, but removing the lines didn't
  seem to have any averse effects and it removed the warning for me

0002:
  The member is simply not used anywhere, thus I think it can be removed
  entirely

0003:
  More coding style stuff that I missed in the first pass. I fixed a few overly
  long lines, though there are many lines that are rather long....

0004:
  This patch adjusts the code to a change in Creator which removed the init()
  function.

0005:
  This model seems to be unused. I didn't check the history to figure out why
  it exists, or when that happened. If there's any reason for keeping it,
  leave the patch out.

0006:
   I got a QProcess: Destroyed while still running if I started a application
   on the device without closing the outputpane in between, this patch fixes
   that warning.

0007:
   The AndroidRunConfiguration returns 0 for the configuration widget, which
   lead to a warning: "Cannot add null widget to layout". I think it's okay to 
   return 0 from that function, and thus opted to patch the 
   RunSettingsPropertiesPage. I'll submit the patch to master, thus there's
   no need to apply it to the android branch.

daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-zorder-from-.ui-file.patch
Type: text/x-patch
Size: 1040 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0007.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Remove-unneeded-member.patch
Type: text/x-patch
Size: 1683 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0008.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Coding-style-changes.patch
Type: text/x-patch
Size: 13863 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0009.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-BuildStepConfigWdiget-init-was-removed-in-2cc7bea-ad.patch
Type: text/x-patch
Size: 2365 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0010.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Remove-dead-code-AndroidDeviceModel.patch
Type: text/x-patch
Size: 4932 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0011.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Prevent-QProcess-Destroyed-while-process-is-still-ru.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0012.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Support-returning-0-from-RunConfiguration-createConf.patch
Type: text/x-patch
Size: 1112 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/necessitas-devel/attachments/20110908/f70d8124/attachment-0013.patch>


More information about the Necessitas-devel mailing list