Merging the android plugin to Qt Creator

[Daniel Teske]

On Tuesday 26 Jul 2011 15:25:40 Teske Daniel (Nokia-MP-Qt/Berlin) wrote:
> > >>  >0005-Simplfy-template-code.patch
> > >>  
> > >>  Not pushed, without setBaseUrl thing, qml engine will add file:// in
> > >>  front of  the file and it will not work with current android assets
> > >>  implementation which need a file patch to start with a "/" or
> > > 
> > > directly
> > > 
> > >>  with its name.
> > > 
> > > Ah, that's reason. then I'd suggest moving the setBaseUrl to the
> > > private, that
> > > is applying the patch + readding the setBaseUrl in the private class.
> > 
> > Sorry, you lost me :) ... a little more help will be very appreciated :)
> 
> Actually, what I suggested wouldn't work. I just dislike the setting of
> baseUrl in a method called setMainQml. The user might opt to not call it.
> Maybe it's best moved to the constructor, like in the attached patch.
> Though I wouldn't be too concerned to leave that open for now.
> 
> daniel

Correct patch attached.

-- 
Daniel Teske
Software Engineer
Nokia, Qt Development Frameworks

Nokia gate5 GmbH
Firmensitz: Invalidenstr. 117, 10115 Berlin, Germany
Registergericht: Amtsgericht Charlottenburg, Berlin: HRB 106443 B
Umsatzsteueridentifikationsnummer: DE 812 845 193
Geschäftsführer: Dr. Michael Halbherr, Karim Tähtivuori
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simplfy-template-code.patch
Type: text/x-patch
Size: 1927 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/necessitas-devel/attachments/20110726/f329c137/attachment.patch