[MassifVisualizer] Review Request 120541: Add possibility to export chart as .svg file

Milian Wolff mail at milianw.de
Thu Oct 9 15:20:43 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120541/#review68167
-----------------------------------------------------------

Ship it!


one minor nitpick then I'm OK with it - cool to see how easy that is. thanks!


app/charttab.cpp
<https://git.reviewboard.kde.org/r/120541/#comment47509>

    nitpickery: I'd prefer a case-insensitive compare instead.
    
        if (!QFileInfo...suffix().compare(QLatin1String("svg")) { ... }



app/charttab.cpp
<https://git.reviewboard.kde.org/r/120541/#comment47511>

    remove empty line


- Milian Wolff


On Oct. 9, 2014, 1:46 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120541/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 1:46 p.m.)
> 
> 
> Review request for Massif Visualizer and Milian Wolff.
> 
> 
> Repository: massif-visualizer
> 
> 
> Description
> -------
> 
> It was so far possible to export chart as bitmap graphics, we can now export them as .svg file.
> 
> 
> Diffs
> -----
> 
>   app/charttab.cpp 61fdd29 
> 
> Diff: https://git.reviewboard.kde.org/r/120541/diff/
> 
> 
> Testing
> -------
> 
> Manual testing, works as expected.
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20141009/0b38a7b2/attachment-0001.html>


More information about the Massif-visualizer mailing list