[MassifVisualizer] Review Request 121381: [OS X] correct isnan/isinf dependency
Milian Wolff
mail at milianw.de
Sun Dec 7 21:47:49 UTC 2014
> On Dec. 7, 2014, 3:07 p.m., Milian Wolff wrote:
> > no clue about mac, so +1 from my side
>
> René J.V. Bertin wrote:
> Done.
>
> Someone tested the code as I found it, right?
What do you mean with your last sentence?
- Milian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121381/#review71512
-----------------------------------------------------------
On Dec. 7, 2014, 6:54 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121381/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2014, 6:54 p.m.)
>
>
> Review request for KDE Software on Mac OS X and Massif Visualizer.
>
>
> Repository: massif-visualizer
>
>
> Description
> -------
>
> The current version of massif-visualizer assumes in KDABLibFakes.h that OS X doesn't have isnan() and isinf() but instead provides the std:: versions of the same via cmath if `_GLIBCPP_USE_C99` is defined. This is not true on OS X 10.9, and earlier versions also provide the traditional isnan() and isinf() functions through math.h .
> It appears to be necessary to provide an explicit cast to double, though, so that `Value` class instances are accepted.
>
>
> Diffs
> -----
>
> kdchart/kdablibfakes/src/KDABLibFakes.h dafd261
>
> Diff: https://git.reviewboard.kde.org/r/121381/diff/
>
>
> Testing
> -------
>
> On Mac OS X 10.9.4 .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20141207/6bf31a11/attachment-0001.html>
More information about the Massif-visualizer
mailing list