[MassifVisualizer] Review Request 117375: Bug 332833 - Support loading kgraphviewer via KPluginFactory

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117375/#review56230
-----------------------------------------------------------

Ship it!


sorry for the long delay - this looks good!

thanks

- Milian Wolff


On April 4, 2014, 8:19 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117375/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 8:19 p.m.)
> 
> 
> Review request for Massif Visualizer.
> 
> 
> Bugs: 332833
>     https://bugs.kde.org/show_bug.cgi?id=332833
> 
> 
> Repository: massif-visualizer
> 
> 
> Description
> -------
> 
> Update code to support loading kgraphviewer via KPluginFactory.
> 
> 
> Diffs
> -----
> 
>   app/documentwidget.cpp 7fdb154 
>   app/mainwindow.cpp 630d8e9 
> 
> Diff: https://git.reviewboard.kde.org/r/117375/diff/
> 
> 
> Testing
> -------
> 
> It works, it causes a very small glitch though. Sounds reasonable to me to first fix the loading then to fix the glitch via another commit.
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20140422/9a9f9a4a/attachment.html>