[MassifVisualizer] Review Request 113288: Delete the print preview dialog just after it has been closed.
Milian Wolff
mail at milianw.de
Thu Oct 17 08:58:56 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113288/#review41869
-----------------------------------------------------------
I always forget whether dialogs get deleted on close or not. If this is not the case, please set the appropriate attribute instead to have this done automatically:
dlg->setAttribute(Qt::WA_DeleteOnClose)
- Milian Wolff
On Oct. 16, 2013, 7:03 p.m., Arnold Dumas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113288/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 7:03 p.m.)
>
>
> Review request for Massif Visualizer.
>
>
> Repository: massif-visualizer
>
>
> Description
> -------
>
> The print preview is only deleted when the application is closed. I think it's better to delete the preview dialog just after it has been closed.
>
>
> Diffs
> -----
>
> app/mainwindow.cpp 3d3d1af
>
> Diff: http://git.reviewboard.kde.org/r/113288/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arnold Dumas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20131017/5572800e/attachment.html>
More information about the Massif-visualizer
mailing list