[MassifVisualizer] Review Request 113523: Implementation of multiple document interface

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113523/#review42828
-----------------------------------------------------------



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/113523/#comment30976>

    I'd say stick to DocumentWidget -> QWidget and hide the stacked widget internally. 



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/113523/#comment30977>

    No, please stick to ParseJobs (separate from the GUI widget) and ThreadWeaver. Don't follow my bad design choices when I started writing this code by putting as much as possible into a single file ;-)
    
    The parse job should have a progress(int) signal or similar. This then should be hooked up to a setProgress() slot on the widget. When the parse job is finished it transmits its data via a signal to a slot in the widget which then swasps the progress bar with the charts.



app/mainwindow.cpp
<http://git.reviewboard.kde.org/r/113523/#comment30978>

    In open file (not the slot which reacts on "parsing finished"), you should directly add the document widget, i.e. just append it to the tab bar. By default, the document widget should show the progress bar until it gets some data set which it can then visualize in charts.


- Milian Wolff


On Oct. 31, 2013, 5:23 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113523/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 5:23 p.m.)
> 
> 
> Review request for Massif Visualizer.
> 
> 
> Repository: massif-visualizer
> 
> 
> Description
> -------
> 
> All the former logic of creating the charts, the legend ... etc is now contained in the MassifDocumentWidget.
> This widget is instanciated by the top-most tab widget. When the active tab changes, the massifDocumentChanged slot is called.
> Some actions are enabled/disabled regarding of the situation. I noticed no particular bug or misbehavior when testing.
> One more thing needs to be done: parallel file loading using ThreadWeaver.
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt 31290f6 
>   app/main.cpp be938b4 
>   app/mainwindow.h 2acc6a8 
>   app/mainwindow.cpp b33ff60 
>   app/mainwindow.ui 8ac4119 
>   app/massifdocumentwidget.h PRE-CREATION 
>   app/massifdocumentwidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/massif-visualizer/attachments/20131102/8748815a/attachment.html>