D25474: Migrate wallpaper config UI to Qt Quick Controls 2 and Kirigami

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> config.qml:20
>  import QtQuick.Layouts 1.0
> -import QtQuick.Controls 1.0 as QtControls
> -
> -// for "units"
> -import org.kde.plasma.core 2.0 as PlasmaCore
> +import QtQuick.Controls 2.0 as QtControls
> +import org.kde.kirigami 2.4 as Kirigami

`import QtQuick.Controls 2.5 as QQC2`

> config.qml:21
> +import QtQuick.Controls 2.0 as QtControls
> +import org.kde.kirigami 2.4 as Kirigami
>  

2.5

> config.qml:31
>  
> -    // To allow aligned integration in the settings form,
> -    // "formAlignment" is a property injected by the config containment
> -    // which defines the offset of the value fields
> -    readonly property int labelWidth: formAlignment - units.largeSpacing
> -
> -    RowLayout {
> -        spacing: units.largeSpacing / 2
> +    Kirigami.FormLayout {
> +        twinFormLayouts: globalSettingsLayout

This should be the top-level layout now; no need to keep it inside a ColumnLayout

> config.qml:75
>  
> -    Item { // tighten layout
> +    Item {
> +        Layout.fillWidth: true

This will no longer be needed and can be removed

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D25474

To: guoyunhe, #marble, #plasma
Cc: ngraham, marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20191122/33167d87/attachment-0001.html>