D11853: Fix Bug 371010: Position Marker is gone/invisible
Colin Stagner
noreply at phabricator.kde.org
Sun Apr 1 01:02:08 UTC 2018
cstagner created this revision.
cstagner added a reviewer: Marble.
cstagner added a project: Marble.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
cstagner requested review of this revision.
REVISION SUMMARY
The position marker plugin queries the direction of "north" by computing latitude + 0.1 radians. This point can be off the screen, however, and the rendering function will early-out.
Skip the off-the-screen check for this northing point.
TEST PLAN
1. Resize the main Marble window to be no more than 768 pixels tall.
2. Switch to the Mercator view
3. Supply Marble with a valid position from any source
4. Zoom in to no more than five ticks from maximally-zoomed in
5. Ensure bug can be reproduced
6. Apply patch
7. Ensure position marker is visible under the above conditions
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D11853
AFFECTED FILES
src/plugins/render/positionmarker/PositionMarker.cpp
To: cstagner, #marble
Cc: cstagner, #kde_edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser, marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20180401/cbe8d156/attachment.html>
More information about the Marble-devel
mailing list